-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Firebase version to avoid compilation freeze on iOS #460
Conversation
<pod name="Firebase/Performance" spec="6.28.1"/> | ||
<pod name="Firebase/RemoteConfig" spec="6.28.1"/> | ||
<pod name="Firebase/InAppMessaging" spec="6.28.1"/> | ||
<pod name="Firebase/Firestore" spec="6.28.1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pre-compiled version of Firestore needs to be kept as it significantly reduces build times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pre-compiled version of Firestore needs to be kept as it significantly reduces build times
The pre-compiler firestore version freeze the ios compilation on my side.
Ionic:
Ionic CLI : 6.10.1 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 5.2.3
@angular-devkit/build-angular : 0.1000.3
@angular-devkit/schematics : 10.0.3
@angular/cli : 10.0.3
@ionic/angular-toolkit : 2.2.0
Cordova:
Cordova CLI : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : android 8.1.0, electron 1.1.1, ios 5.1.1
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.1, (and 8 other plugins)
Utility:
cordova-res (update available: 0.15.1) : 0.14.0
native-run : 1.0.0
System:
ios-deploy : 1.10.0
ios-sim : 8.0.2
NodeJS : v12.16.1 (/usr/local/bin/node)
npm : 6.13.4
OS : macOS Catalina
Xcode : Xcode 11.6 Build version 11E708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example project builds fine for me with cordova-plugin-firebasex@10.1.2
in Xcode 11.5 and Xcode 12.0 Beta 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I follow the readme :
git clone https://github.com/dpa99c/cordova-plugin-firebasex-test.git && cd cordova-plugin-firebasex-test
npm install
cordova platform add ios
cordova run ios
I obtain a build failed on the same step i'm freeze on my project :
PhaseScriptExecution [CP]\ Copy\ Pods\ Resources /Users/damienblanchet/Library/Developer/Xcode/DerivedData/FirebaseTest-cqjrdjtdzlwcmiehwgvhhflbbajx/Build/Intermediates.noindex/FirebaseTest.build/Debug-iphonesimulator/FirebaseTest.build/Script-71CBF5A57D83BC59C2384146.sh (in target 'FirebaseTest' from project 'FirebaseTest')
cd /Users/damienblanchet/Sources/cordova-plugin-firebasex-test/platforms/ios
/bin/sh -c /Users/damienblanchet/Library/Developer/Xcode/DerivedData/FirebaseTest-cqjrdjtdzlwcmiehwgvhhflbbajx/Build/Intermediates.noindex/FirebaseTest.build/Debug-iphonesimulator/FirebaseTest.build/Script-71CBF5A57D83BC59C2384146.sh
/Users/damienblanchet/Sources/cordova-plugin-firebasex-test/platforms/ios/Pods/FirebaseFirestore/FirebaseFirestore/Resources/gRPCCertificates-Cpp.bundle
error: Resource "/Users/damienblanchet/Library/Developer/Xcode/DerivedData/FirebaseTest-cqjrdjtdzlwcmiehwgvhhflbbajx/Build/Products/Debug-iphonesimulator/FirebaseInAppMessaging/InAppMessagingDisplayResources.bundle" not found. Run 'pod install' to update the copy resources script.
** BUILD FAILED **
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I applied the modifications of this paragraph and I got a build success. I will investigate on my side to try to identify the issue
Fixed in |
@dpa99c
cordova plugin lists are below.
After remove cordova-plugin-firebasex plugin, I can see build succeed.. |
@Younghun-Jung Yes I have the same problem when trying to build with the command line (using firebasex@10.1.2-cli). The build just hangs. It looks like it may be a cocoapods issue that others have reported elsewhere: https://sugeul.github.io/2020-06-02-xcodebuild-hang-on-CP-Prepare-artifacts/ Unfortunately there doesn't seem to be any official fix available at this point. I have tried editing the generated "Pods--artifacts.sh file and changing this line: I can then run cordova build ios and it works. However, as this is a generated file, my change will get overwritten any time cordova recreates the project. I may consider trying to come up with a cordova hook to do this edit automatically ... but hoping somebody else has a better idea. |
I upgraded to CocoaPods latest beta, 1.10.0.beta.2 with |
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
Fix Firebase version to avoid compilation freeze on iOS
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
resolve freeze issue on ios compilation
What testing has been done on existing functionality?
Other information