Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

CI Build failing: Investigate order of fields in JSON #901

Closed
nathanfletcher opened this issue Dec 2, 2021 · 3 comments
Closed

CI Build failing: Investigate order of fields in JSON #901

nathanfletcher opened this issue Dec 2, 2021 · 3 comments
Assignees

Comments

@nathanfletcher
Copy link
Collaborator

The automated CI failed upon submission for Kindly

Look into the positions of the JSON keys
"implementBestPractices": "Yes",
"griefAbuseHarassmentProtection": "Yes",

https://github.com/unicef/publicgoods-candidates/runs/4385086080?check_suite_focus=true

@nathanfletcher nathanfletcher self-assigned this Dec 2, 2021
@lacabra
Copy link
Contributor

lacabra commented Dec 2, 2021

FYI, from what I can see this would be an issue of the schema of the submission form, so I recommend to start there, and possibly open an issue in that repo instead of this one, but your investigations will confirm this hypothesis ;)

@nathanfletcher
Copy link
Collaborator Author

nathanfletcher commented Dec 7, 2021

@lacabra after investigating again, I believe this is coming from screening-schema.json in this repo.
So I'm currently comparing it to the submissions repo schema.js
I believe they should be the same. Am I correct?

I'm still working on it.

@lacabra
Copy link
Contributor

lacabra commented Dec 7, 2021

@nathanfletcher Yes, they should match (they aren't exactly the same because the data structure is different). And if you have to make changes in one of the two, make them in the submission form one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants