Revert 703f0659 / fix 0.8.2 protocol quick detection #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 703f065 was attempting to fix version detection on 0.8.2 brokers, which have a quirky correlation id response for GroupCoordinator requests when there are no topics created. But setting the BrokerConn api_version to 0.8.2 prematurely inadvertently broke SASL authentication, which checks that the api_version is either unset (None) or >= 0.10 . This PR should fix both issues by also handling the 0.8.2 protocol quirk when the api_version is unset / None.
This change is