Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka client edits #332

Merged
merged 5 commits into from
Mar 8, 2015
Merged

Kafka client edits #332

merged 5 commits into from
Mar 8, 2015

Commits on Mar 1, 2015

  1. Accept KafkaClient client_id as string or bytes; encode string client… 

    …_id as utf-8 bytes internally
    Dana Powers committed Mar 1, 2015
    Configuration menu
    Copy the full SHA
    9f7d612 View commit details
    Browse the repository at this point in the history

  2. Remove KafkaConsumer.BYTES_CONFIGURATION_KEYS 

    - rely on KafkaClient to handle client_id string/bytes encoding
- accept either string or bytes for group_id
- convert group_id string to utf-8 bytes internally
    Dana Powers committed Mar 1, 2015
    Configuration menu
    Copy the full SHA
    0f04eba View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2015

  1. Avoid topic_partitions KeyError in KafkaClient

    Dana Powers committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    082cda6 View commit details
    Browse the repository at this point in the history

  2. Add comment about no server response case in _send_broker_aware_request

    Dana Powers committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    83d28ba View commit details
    Browse the repository at this point in the history

  3. KafkaClient.get_partition_ids_for_topic now returns empty list for un… 

    …known topics
    Dana Powers committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    c80fbd1 View commit details
    Browse the repository at this point in the history