Kafka client edits #332

dpkp · 2015-03-02T17:50:33Z

A few small cleanups to KafkaClient:

accept client_id and group_id as string or bytes
avoid topic_partition KeyError
return empty list from get_partition_ids_for_topic for unknown topics
to make the return type consistent (always a list)

…_id as utf-8 bytes internally

- rely on KafkaClient to handle client_id string/bytes encoding - accept either string or bytes for group_id - convert group_id string to utf-8 bytes internally

…known topics

Kafka client edits

Dana Powers added 5 commits March 1, 2015 11:04

Accept KafkaClient client_id as string or bytes; encode string client…

9f7d612

…_id as utf-8 bytes internally

Remove KafkaConsumer.BYTES_CONFIGURATION_KEYS

0f04eba

- rely on KafkaClient to handle client_id string/bytes encoding - accept either string or bytes for group_id - convert group_id string to utf-8 bytes internally

Avoid topic_partitions KeyError in KafkaClient

082cda6

Add comment about no server response case in _send_broker_aware_request

83d28ba

KafkaClient.get_partition_ids_for_topic now returns empty list for un…

c80fbd1

…known topics

dpkp mentioned this pull request Mar 2, 2015

WIP: KafkaProducer #333

Closed

dpkp added a commit that referenced this pull request Mar 8, 2015

Merge pull request #332 from dpkp/kafka_client_edits

327b734

Kafka client edits

dpkp merged commit 327b734 into dpkp:master Mar 8, 2015

dpkp deleted the kafka_client_edits branch June 10, 2015 00:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kafka client edits #332

Kafka client edits #332

dpkp commented Mar 2, 2015

Kafka client edits #332

Kafka client edits #332

Conversation

dpkp commented Mar 2, 2015