Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caculate time_ranges #14

Closed
wutongluxjtu opened this issue Nov 13, 2015 · 0 comments
Closed

caculate time_ranges #14

wutongluxjtu opened this issue Nov 13, 2015 · 0 comments

Comments

@wutongluxjtu
Copy link

Hi, professor Dan
Shouldn't the _caculate_time_ranges() function modified as:

def _calculate_time_ranges(self, hits, id, mode, mintime):
"""Given the id and mode, return the actual time support."""
match_times = sorted(hits[row, 3]
for row in np.nonzero(hits[:, 0]==id)[0]
if mode + mintime - self.window <= hits[row, 1]
and hits[row, 1] <= mode + mintime + self.window)

and execute: min_time, max_time = self._calculate_time_ranges(hits, id, mode, mintime) in _approx_match_counts().

since (mode+mintime) physically indicates real time_skew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant