Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup Heroku Review Apps #66

Closed
tooomm opened this issue Nov 5, 2017 · 4 comments
Closed

setup Heroku Review Apps #66

tooomm opened this issue Nov 5, 2017 · 4 comments

Comments

@tooomm
Copy link
Contributor

tooomm commented Nov 5, 2017

It's a pretty fancy and useful tool to check changes within PR's live!
We should be all good with just the free plan, and it seamlessly integrates with GitHub.

Announcement in blog: https://blog.heroku.com/heroku-review-apps-ga
Documentation: https://devcenter.heroku.com/articles/github-integration-review-apps

Other (hopefully helpful) links:
https://github.com/infusionsoft/heroku-review-app-guide
http://blog.skorfmann.com/heroku-review-apps
https://robots.thoughtbot.com/running-acceptance-with-review-apps

@HerveH44 you had some concerns or additional requirements that would need to change before we could use it. Can you let us know here again, please?


Note: https://zeit.co/now could be an interesting alternative

@HerveH44
Copy link
Contributor

HerveH44 commented Nov 6, 2017

Hey,

From my point of vue, right now our app runs through a Make command, and not directly through NodeJs. I think we need to focus on putting all the make commands inside NodeJs package.json as scripts and then have the app runs through simple "npm start", because that's a requisite from Heroku Apps.

For example, all the links created, the big AllSets JSON download, should be done through new scripts, and put an entry inside package.json like "postinstall". Because that's what Heroku is going to trigger after he does "npm install".

I'll put some more information soon, when I am finished with the refactoring.

Bye !

Hervé

@HerveH44
Copy link
Contributor

Just for information,

it's super simple to set review apps, and it works fine. I just tried it with my branch refactor_frontend.

@dev-id Would you like to create an account on Heroku ?

@tooomm
Copy link
Contributor Author

tooomm commented Jan 3, 2018

Not useful yet. But first bits got merged, want to outline that here for reference: 42da657 (as part of #29)

@HerveH44
Copy link
Contributor

Fixed with commit : 031f834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants