Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'found' text hard to read #14

Open
lemzwerg opened this issue May 9, 2023 · 5 comments
Open

'found' text hard to read #14

lemzwerg opened this issue May 9, 2023 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lemzwerg
Copy link

lemzwerg commented May 9, 2023

If I search for some text, the found text is highlighted with a yellow background but with a white foreground, which makes it very hard to read.

I see a currentsearchhitbgcolor property. Does a currentsearchhitfgcolor exist, too?

This is on openSUSE GNU/Linux using gitk coming with git 2.40.1.

image

@lemzwerg
Copy link
Author

BTW, in the image you can also see that the 'up' and 'down' buttons after the 'Lines of context' field don't fit the dark theme, inspite of having want_ttk 0 in my config file. Is this a known problem?

@lourot
Copy link
Member

lourot commented Jun 14, 2023

Thanks @lemzwerg, unfortunately the yellow color doesn't come from currentsearchhitbgcolor. I have tried changing all the yellow-ish values to black in my config and this remained yellow. I believe gitk doesn't give us the option to tweak this color unfortunately.

And I believe the same applies for the 'up' and 'down' buttons your are mentioning.

@lourot lourot added bug Something isn't working help wanted Extra attention is needed labels Jun 14, 2023
@lemzwerg
Copy link
Author

OK, thanks. Please file an issue for gitk so that it gets fixed eventually!

@lourot
Copy link
Member

lourot commented Jun 14, 2023

gitk's source code is mirrored at https://github.com/git/git/tree/master/gitk-git and I think issues have to be reported on the mailing list described at https://git-scm.com/community

@lemzwerg
Copy link
Author

OK. Sorry that I don't volunteer by myself, but don't have time to handle this additionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

2 participants