comments hard to read when highlighted

[bricerebsamen]

What happened

comments are very hard to read when highlighted. This started happening after I upgraded the plugin (I did that a few weeks back so I can't tell you from which rev to which).

What I expected to happen

Screenshot

Machine Info

• Vim type (vim/gvim/neovim): vim
• Vim version: 8.0
• OS: Linux cube219 4.4.0-124-generic #148~14.04.1-Ubuntu SMP Thu May 3 07:26:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• Terminal/Terminal Emulator/VTE: tmux 2.0
• TERM environment variable: screen-256color

Additional Info

$ tmux info
started Wed Jun  6 15:32:19 2018
socket path /tmp/user/1001/tmux-1001/default
debug level 0
protocol version 8

Terminal 0: xterm [references=1, flags=0x0]:
   1: acsc: (string) ``aaffggiijjkkllmmnnooppqqrrssttuuvvwwxxyyzz{{||}}~~
   0: AX: (flag) true
   2: bel: (string) \007
   3: blink: (string) \033[5m
   4: bold: (string) \033[1m
   5: civis: (string) \033[?25l
   6: clear: (string) \033[H\033[2J
   7: cnorm: (string) \033[?12l\033[?25h
   8: colors: (number) 8
   9: Cr: (string) \033]112\007
  10: Cs: (string) \033]12;%p1%s\007
  11: csr: (string) \033[%i%p1%d;%p2%dr
  12: cub: (string) \033[%p1%dD
  13: cub1: (string) \010
  14: cud: (string) \033[%p1%dB
  15: cud1: (string) \012
  16: cuf: (string) \033[%p1%dC
  17: cuf1: (string) \033[C
  18: cup: (string) \033[%i%p1%d;%p2%dH
  19: cuu: (string) \033[%p1%dA
  20: cuu1: (string) \033[A
  21: cvvis: (string) \033[?12;25h
  22: dch: (string) \033[%p1%dP
  23: dch1: (string) \033[P
  24: dim: [missing]
  25: dl: (string) \033[%p1%dM
  26: dl1: (string) \033[M
  27: E3: [missing]
  28: ech: (string) \033[%p1%dX
  29: el: (string) \033[K
  30: el1: (string) \033[1K
  31: enacs: [missing]
  32: fsl: (string) \007
  33: home: (string) \033[H
  34: hpa: (string) \033[%i%p1%dG
  35: ich: (string) \033[%p1%d@
  36: ich1: [missing]
  37: il: (string) \033[%p1%dL
  38: il1: (string) \033[L
  39: invis: (string) \033[8m
  40: is1: [missing]
  41: is2: (string) \033[!p\033[?3;4l\033[4l\033>
  42: is3: [missing]
  43: kcbt: (string) \033[Z
  44: kcub1: (string) \033OD
  45: kcud1: (string) \033OB
  46: kcuf1: (string) \033OC
  47: kcuu1: (string) \033OA
  48: kDC: (string) \033[3;2~
  49: kDC3: (string) \033[3;3~
  50: kDC4: (string) \033[3;4~
  51: kDC5: (string) \033[3;5~
  52: kDC6: (string) \033[3;6~
  53: kDC7: (string) \033[3;7~
  54: kdch1: (string) \033[3~
  55: kDN: (string) \033[1;2B
  56: kDN3: (string) \033[1;3B
  57: kDN4: (string) \033[1;4B
  58: kDN5: (string) \033[1;5B
  59: kDN6: (string) \033[1;6B
  60: kDN7: (string) \033[1;7B
  61: kend: (string) \033OF
  62: kEND: (string) \033[1;2F
  63: kEND3: (string) \033[1;3F
  64: kEND4: (string) \033[1;4F
  65: kEND5: (string) \033[1;5F
  66: kEND6: (string) \033[1;6F
  67: kEND7: (string) \033[1;7F
  68: kf1: (string) \033OP
  69: kf10: (string) \033[21~
  70: kf11: (string) \033[23~
  71: kf12: (string) \033[24~
  72: kf13: (string) \033[1;2P
  73: kf14: (string) \033[1;2Q
  74: kf15: (string) \033[1;2R
  75: kf16: (string) \033[1;2S
  76: kf17: (string) \033[15;2~
  77: kf18: (string) \033[17;2~
  78: kf19: (string) \033[18;2~
  79: kf2: (string) \033OQ
  80: kf20: (string) \033[19;2~
  81: kf21: (string) \033[20;2~
  82: kf22: (string) \033[21;2~
  83: kf23: (string) \033[23;2~
  84: kf24: (string) \033[24;2~
  85: kf25: (string) \033[1;5P
  86: kf26: (string) \033[1;5Q
  87: kf27: (string) \033[1;5R
  88: kf28: (string) \033[1;5S
  89: kf29: (string) \033[15;5~
  90: kf3: (string) \033OR
  91: kf30: (string) \033[17;5~
  92: kf31: (string) \033[18;5~
  93: kf32: (string) \033[19;5~
  94: kf33: (string) \033[20;5~
  95: kf34: (string) \033[21;5~
  96: kf35: (string) \033[23;5~
  97: kf36: (string) \033[24;5~
  98: kf37: (string) \033[1;6P
  99: kf38: (string) \033[1;6Q
 100: kf39: (string) \033[1;6R
 101: kf4: (string) \033OS
 102: kf40: (string) \033[1;6S
 103: kf41: (string) \033[15;6~
 104: kf42: (string) \033[17;6~
 105: kf43: (string) \033[18;6~
 106: kf44: (string) \033[19;6~
 107: kf45: (string) \033[20;6~
 108: kf46: (string) \033[21;6~
 109: kf47: (string) \033[23;6~
 110: kf48: (string) \033[24;6~
 111: kf49: (string) \033[1;3P
 112: kf5: (string) \033[15~
 113: kf50: (string) \033[1;3Q
 114: kf51: (string) \033[1;3R
 115: kf52: (string) \033[1;3S
 116: kf53: (string) \033[15;3~
 117: kf54: (string) \033[17;3~
 118: kf55: (string) \033[18;3~
 119: kf56: (string) \033[19;3~
 120: kf57: (string) \033[20;3~
 121: kf58: (string) \033[21;3~
 122: kf59: (string) \033[23;3~
 123: kf6: (string) \033[17~
 124: kf60: (string) \033[24;3~
 125: kf61: (string) \033[1;4P
 126: kf62: (string) \033[1;4Q
 127: kf63: (string) \033[1;4R
 128: kf7: (string) \033[18~
 129: kf8: (string) \033[19~
 130: kf9: (string) \033[20~
 131: kHOM: (string) \033[1;2H
 132: kHOM3: (string) \033[1;3H
 133: kHOM4: (string) \033[1;4H
 134: kHOM5: (string) \033[1;5H
 135: kHOM6: (string) \033[1;6H
 136: kHOM7: (string) \033[1;7H
 137: khome: (string) \033OH
 138: kIC: (string) \033[2;2~
 139: kIC3: (string) \033[2;3~
 140: kIC4: (string) \033[2;4~
 141: kIC5: (string) \033[2;5~
 142: kIC6: (string) \033[2;6~
 143: kIC7: (string) \033[2;7~
 144: kich1: (string) \033[2~
 145: kLFT: (string) \033[1;2D
 146: kLFT3: (string) \033[1;3D
 147: kLFT4: (string) \033[1;4D
 148: kLFT5: (string) \033[1;5D
 149: kLFT6: (string) \033[1;6D
 150: kLFT7: (string) \033[1;7D
 151: kmous: (string) \033[M
 152: knp: (string) \033[6~
 153: kNXT: (string) \033[6;2~
 154: kNXT3: (string) \033[6;3~
 155: kNXT4: (string) \033[6;4~
 156: kNXT5: (string) \033[6;5~
 157: kNXT6: (string) \033[6;6~
 158: kNXT7: (string) \033[6;7~
 159: kpp: (string) \033[5~
 160: kPRV: (string) \033[5;2~
 161: kPRV3: (string) \033[5;3~
 162: kPRV4: (string) \033[5;4~
 163: kPRV5: (string) \033[5;5~
 164: kPRV6: (string) \033[5;6~
 165: kPRV7: (string) \033[5;7~
 166: kRIT: (string) \033[1;2C
 167: kRIT3: (string) \033[1;3C
 168: kRIT4: (string) \033[1;4C
 169: kRIT5: (string) \033[1;5C
 170: kRIT6: (string) \033[1;6C
 171: kRIT7: (string) \033[1;7C
 172: kUP: (string) \033[1;2A
 173: kUP3: (string) \033[1;3A
 174: kUP4: (string) \033[1;4A
 175: kUP5: (string) \033[1;5A
 176: kUP6: (string) \033[1;6A
 177: kUP7: (string) \033[1;7A
 178: Ms: (string) \033]52;%p1%s;%p2%s\007
 179: op: (string) \033[39;49m
 180: rev: (string) \033[7m
 181: ri: (string) \033M
 182: rmacs: (string) \033(B
 183: rmcup: (string) \033[?1049l
 184: rmkx: (string) \033[?1l\033>
 185: Se: (string) \033[2 q
 186: setab: (string) \033[4%p1%dm
 187: setaf: (string) \033[3%p1%dm
 188: sgr0: (string) \033(B\033[m
 189: sitm: [missing]
 190: smacs: (string) \033(0
 191: smcup: (string) \033[?1049h
 192: smkx: (string) \033[?1h\033=
 193: smso: (string) \033[7m
 194: smul: (string) \033[4m
 195: Ss: (string) \033[%p1%d q
 196: tsl: (string) \033]0;
 197: vpa: (string) \033[%i%p1%dd
 198: xenl: (flag) true
 199: XT: (flag) true

[benknoble]

I believe we've seen this before in various forms...

For example, it's mentioned in #37, which was supposedly closed by #62

However, I agree it still obscures comments. My one thought is that perhaps we shouldn't be reading comments when visually-selecting them? But still, anything we can do to make this a non-issue would be good.

@bricerebsamen do you have any suggestions on what might make a good replacement color for the DraculaSelection highlight color?

[bricerebsamen]

we shouldn't be reading comments when visually-selecting them

sure but that's still a problem when editing the comments

[benknoble]

Agreed; that's why I'm asking for suggestions for a fix and recommending we fix it

[bricerebsamen]

can you suggest a way for me to experiment? i.e. some vimrc line like let g:DraculaSelection = #rrggbb with the current color value. I can try to tweak and propose a new value.

[bricerebsamen]

also maybe the proper tweak is to change the comment color to a slightly lighter value. same question: how would I experiment with that?

[benknoble]

DraculaSelection is defined here.

The selection value referenced above comes from here and is a list of

[ '#rrggbb' , closest_256-color_equivalent ]

Comment would be changed by experimenting with DraculaComment in that same file.

You'd most likely want to play around with a local copy of the repo and tweak the values in the colors file. You could edit it directly in your ~/.vim directory (idk your setup), or clone it fresh and start tweaking. Just make sure if you that you point your runtimepath over to the right copy so you can use that.

If you don't want to go to all that, you could probably try this in a vim session, but the above is more surefire.

:hi DraculaSelection [key]=[arg] " see :help :hi

[dsifford]

If I'm able to interject here 3 days later, I'd much rather see this discussed and changed here before doing anything drastic in this repo.

If there is agreement that this is a problem, the change should happen at the spec level, not at the implementation level.

At the end of the day, decisions like this should be left to @zenorocha

[zx1986]

I got the same problem too!
How did you fix this? @bricerebsamen

[bs]

Hitting this as well.

[benknoble]

Closing this until we get resolution on dracula/dracula-theme#318