Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments hard to read when highlighted #318

Closed
bricerebsamen opened this issue Mar 21, 2019 · 7 comments
Closed

comments hard to read when highlighted #318

bricerebsamen opened this issue Mar 21, 2019 · 7 comments
Assignees
Labels
🤔 discuss Something needs to be discussed to move forward or reach a resolution

Comments

@bricerebsamen
Copy link

comments are very hard to read when highlighted (vim c++). See dracula/vim#95

Screenshot

selection_036

@bricerebsamen
Copy link
Author

I really love dracula otherwise, but this has become too much of a pain point so I'm switching to jellybean for the time being

@ahnaf-rafi
Copy link

I second this. For (neo)vim I have adjusted this by changing the highlight color for the current line in my init.vim to make it darker than the background (so that it is distinguishable from the background and allows for greater contrast against the colors for comments). I checked for the hex code for hsl(231, 15%, 12%) and it is #1a1b23 (the background has the same first two arguments, but it is 18% at the end). I made this the highlighting for the current line by including
highlight CursorLine cterm=NONE ctermbg=234 guibg=#1a1b23
in my init.vim after calling syntax on. It would be great though if something similar could be made default (with better color choices from those more visually adept than myself) - this solution is hacky at best, and doesn't improve legibility for comments across the board for other editors, only for (neo)vim!

@ahnaf-rafi
Copy link

ahnaf-rafi commented Jun 23, 2019

The end result looks like this for me:
Screenshot from 2019-06-23 22-24-44

@hacknug hacknug added the 🤔 discuss Something needs to be discussed to move forward or reach a resolution label Jun 26, 2019
@hacknug
Copy link
Member

hacknug commented Jun 26, 2019

Agree this could/should be improved. Would like to hear other opinions on the issue before we make any changes to the color palette 👍

@marcbecc
Copy link

I switched away from this theme because of this issue

@zx1986
Copy link

zx1986 commented Mar 12, 2020

me too :-( @shrek6

@benknoble
Copy link
Member

Is there any forward progress on trying different values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤔 discuss Something needs to be discussed to move forward or reach a resolution
Development

No branches or pull requests

8 participants