-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA: State change activity #1134
Conversation
@@ -30,4 +30,8 @@ def track_recovered(trackable, user: current_user, project: current_project) | |||
def track_updated(trackable, user: current_user, project: current_project) | |||
track_activity(trackable, :update, user, project) | |||
end | |||
|
|||
def track_updated_state(trackable, user: current_user, project: current_project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't love the name here, and looking at the presenter further down, what'd be the point of splitting the methods, and the action if we're not going to differentiate the view?
It seems to me that what we care about it's not the updating on an attribute, but the change in the QA state. Naming convention around QA state, and displaying a related message would be more useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the name to track_state_change
.
We are differentiating the view here
Summary
Track state changes and render them in the activity feed
Check List
- [ ] Added a CHANGELOG entry