Add support for GET parameters #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpme
reviewed
Feb 20, 2018
twitter.js
Outdated
| @@ -52,9 +53,11 @@ class Twitter { | |||
|
|
|||
| async get(resource) { | |||
| const requestData = { | |||
| url: `${this.url}/${resource}.json`, | |||
| url: `${this.url}/${resource}.json?${querystring.stringify(parameters)}`, | |||
There was a problem hiding this comment.
not passing in parameters anywhere
peterpme
reviewed
Feb 20, 2018
twitter.js
Outdated
| method: "GET" | ||
| }; | ||
| if (parameters) | ||
| requestData.url += "?" + querystring.stringify(parameters); |
There was a problem hiding this comment.
will this duplicate what you've done above under requestData.url?
dandv
commented
Feb 20, 2018
|
Looks great! I made you a collaborator so you can feel free to merge when you're ready! Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I've seen so far, no Twitter APIs take nested objects as parameters, so querystring should suffice. Otherwise, we can use the qs module.