-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for United Kingdom (Northern Ireland) ("GB-NIR") #127
Comments
Yes @jonathanmaron, you're absolutely correct. I suggest that before we remove UK completely (#126) we should first look at integrating Northern Ireland correctly. What I'm missing in the documentation up to this point are the structure definition and which calculation method is being used to verify if this new VAT ID is formatted correctly. Do you have some details about that? |
I would agree with you to add "United Kingdom (Northern Ireland)" before we remove "United Kingdom". The only documentation that I found on the structure of the new XI VAT numbers is at: https://www.avalara.com/vatlive/en/vat-news/brexit-northern-ireland-vat-and-eoro--xi--number.html
According to that, we can simply re-purpose the current "United Kingdom" validator. |
Yes, this can be done. Do you want to replicate the UK validator for Northern Ireland @jonathanmaron, including the tests? |
It would be my pleasure to implement the require classes. |
And done. See pull request #128 |
If you search for some town names in Northern Ireland in the "Enter company name" text entry box at http://www.vat-check.co.uk you can find some real VAT numbers belonging to Northern Ireland businesses. Simply replace "GB" with "XI" for test purposes. |
Merged #128 after updating GitHub Action to test against PHP 7.4 as some components are not yet ready for PHP 8 unfortunately. |
Source: https://ec.europa.eu/taxation_customs/uk_withdrawal_en
We therefore should add support for the "United Kingdom (Northern Ireland)".
Since the new XI VAT numbers for Northern Ireland businesses are just like the GB VAT numbers, we should be able to re-purpose the current GB validator:
Source (and other details): https://www.avalara.com/vatlive/en/vat-news/brexit-northern-ireland-vat-and-eoro--xi--number.html
The text was updated successfully, but these errors were encountered: