Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

test: add unit test case for func GetAsTime #1193

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com

Ⅰ. Describe what this PR did

Add unit test case for func GetAsTime

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test github.com/dragonflyoss/Dragonfly/pkg/syncmap -run Test -v

Ⅴ. Special notes for reviews

Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
@codecov-io
Copy link

Codecov Report

Merging #1193 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   47.72%   47.78%   +0.05%     
==========================================
  Files         115      115              
  Lines        7254     7254              
==========================================
+ Hits         3462     3466       +4     
+ Misses       3513     3508       -5     
- Partials      279      280       +1
Impacted Files Coverage Δ
pkg/syncmap/syncmap.go 56.7% <0%> (+4.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919ff03...77f128e. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants