Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdig kernel module fails to build since Linux 5.0rc4 #1299

Closed
Maryse47 opened this issue Jan 28, 2019 · 1 comment
Closed

sysdig kernel module fails to build since Linux 5.0rc4 #1299

Maryse47 opened this issue Jan 28, 2019 · 1 comment

Comments

@Maryse47
Copy link

Maryse47 commented Jan 28, 2019

It worked for Linux 5.0rc3 and before.

DKMS make.log for sysdig-0.24.2 for kernel 5.0.0-rc4 (x86_64)
make: Entering directory '/usr/lib/modules/5.0.0-rc4/build'
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/main.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/dynamic_params_table.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/fillers_table.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/flags_table.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/ppm_events.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/ppm_fillers.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/event_table.o
  CC [M]  /var/lib/dkms/sysdig/0.24.2/build/syscall_table.o
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c: In function ‘ppm_copy_from_user’:
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:89:48: error: macro "access_ok" passed 3 arguments, but takes just 2
  if (likely(ppm_access_ok(VERIFY_READ, from, n)))
                                                ^
In file included from ./include/linux/export.h:45,
                 from ./include/linux/linkage.h:7,
                 from ./arch/x86/include/asm/cache.h:5,
                 from ./include/linux/cache.h:6,
                 from ./include/linux/time.h:5,
                 from ./include/linux/compat.h:10,
                 from /var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:12:
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:49:23: error: ‘access_ok’ undeclared (first use in this function); did you mean ‘access_flags’?
 #define ppm_access_ok access_ok
                       ^~~~~~~~~
./include/linux/compiler.h:76:40: note: in definition of macro ‘likely’
 # define likely(x) __builtin_expect(!!(x), 1)
                                        ^
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:89:13: note: in expansion of macro ‘ppm_access_ok’
  if (likely(ppm_access_ok(VERIFY_READ, from, n)))
             ^~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:49:23: note: each undeclared identifier is reported only once for each function it appears in
 #define ppm_access_ok access_ok
                       ^~~~~~~~~
./include/linux/compiler.h:76:40: note: in definition of macro ‘likely’
 # define likely(x) __builtin_expect(!!(x), 1)
                                        ^
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:89:13: note: in expansion of macro ‘ppm_access_ok’
  if (likely(ppm_access_ok(VERIFY_READ, from, n)))
             ^~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c: In function ‘ppm_strncpy_from_user’:
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:120:54: error: macro "access_ok" passed 3 arguments, but takes just 2
   if (!ppm_access_ok(VERIFY_READ, from, bytes_to_read)) {
                                                      ^
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:49:23: error: ‘access_ok’ undeclared (first use in this function); did you mean ‘access_flags’?
 #define ppm_access_ok access_ok
                       ^~~~~~~~~
/var/lib/dkms/sysdig/0.24.2/build/ppm_events.c:120:8: note: in expansion of macro ‘ppm_access_ok’
   if (!ppm_access_ok(VERIFY_READ, from, bytes_to_read)) {
        ^~~~~~~~~~~~~
make[1]: *** [scripts/Makefile.build:277: /var/lib/dkms/sysdig/0.24.2/build/ppm_events.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1556: _module_/var/lib/dkms/sysdig/0.24.2/build] Error 2
make: Leaving directory '/usr/lib/modules/5.0.0-rc4/build'
ColinIanKing pushed a commit to ColinIanKing/sysdig that referenced this issue Jan 31, 2019
Linux 5.0 removed the 1st argument 'type' from the access_ok macro.
Update the ppm_access_ok() macro to cater for this change for Linux
5.0

Bug: draios#1299

Signed-off-by: Colin Ian King <colin.king@canonical.com>
ColinIanKing pushed a commit to ColinIanKing/sysdig that referenced this issue Jan 31, 2019
Linux 5.0 removed the 1st argument 'type' from the access_ok macro.
Update the ppm_access_ok() macro to cater for this change for Linux
5.0

Bug: draios#1299
sysdig-CLA-1.0-signed-off-by: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
gnosek pushed a commit that referenced this issue Mar 5, 2019
Linux 5.0 removed the 1st argument 'type' from the access_ok macro.
Update the ppm_access_ok() macro to cater for this change for Linux
5.0

Bug: #1299
sysdig-CLA-1.0-signed-off-by: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
@Maryse47
Copy link
Author

Maryse47 commented Mar 6, 2019

Fixed by #1302

@Maryse47 Maryse47 closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant