Page fault tracepoints can be disabled as with ubuntu-artful (see bel… #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driver/main.c
Outdated
| static struct tracepoint *tp_page_fault_user; | ||
| static struct tracepoint *tp_page_fault_kernel; | ||
| static bool g_fault_tracepoint_registered; | ||
| static bool g_fault_tracepoint_disabled = false; |
There was a problem hiding this comment.
Minor: initializing a static to false is not good practice according to kernel coding conventions, if you run your patch against checkpatch.pl in the kernel tree it should complain.
bertocci
suggested changes
Jan 11, 2018
driver/main.c
Outdated
| @@ -1027,6 +1030,12 @@ static long ppm_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
| #ifdef CAPTURE_PAGE_FAULTS | |||
| ASSERT(g_tracepoint_registered); | |||
|
|
|||
| if (g_fault_tracepoint_disabled) { | |||
| ret = 0; | |||
There was a problem hiding this comment.
We need to return an error here and propagate it to the user. If not, they could run sysdig --page-faults and silently fail.
Return error instead of failing silently when page faults are disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ow). Ignore --page-faults if this is the case.
http://kernel.ubuntu.com/git/ubuntu/ubuntu-artful.git/commit/arch/x86/mm/fault.c?id=4ecc04d14ee2f9b46d3e252215a7622d7d47e974