fix(userspace/sysdig): handle SCAP_FAILURE #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealbobo
force-pushed
the
fix-trunc-scap
branch
3 times, most recently
from
13024ee
to
3b001a9
Compare
therealbobo
force-pushed
the
fix-trunc-scap
branch
2 times, most recently
from
a1c5797
to
05f33a3
Compare
therealbobo
force-pushed
the
fix-trunc-scap
branch
from
d1af05b
to
d1465c5
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
fix-trunc-scap
branch
6 times, most recently
from
ac39975
to
bcab610
Compare
Until now we considered that together with SCAP_EOF rc a valid event was returned. This is no longer the case. Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
fix-trunc-scap
branch
from
bcab610
to
dad1672
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
|
jasondellaluce
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, in case of truncated scap files, we don't handle errors. This handle the failure gracefully and just continues in the event loop.