Add container image ids. #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for displaying container image ids via the filtercheck container.image.id. Only supported for docker containers right now.
|
@ldegio I just realized you added support for image ids in the bline branch. Should I close this and wait for the bline branch to merge? |
|
Actually, this change isn't entirely a subset of the bline changes--this adds the filtercheck in addition to maintaining the image id as internal state. |
|
I would add your changes to the bline branch and then we can bring everything to dev later |
|
Ok, closing this PR, replaced with #661. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for displaying container image ids via the filtercheck
container.image.id. Only supported for docker containers right now.