Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing permission for "Folders" #1349

Closed
2 tasks done
Joshua2504 opened this issue Jul 6, 2023 · 3 comments
Closed
2 tasks done

[Bug]: Missing permission for "Folders" #1349

Joshua2504 opened this issue Jul 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Joshua2504
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration issue.
  • This issue is not already reported on Github (I've searched it).

Bug description

Admin User Permission for the "Folders" section is missing.

Steps to reproduce

  1. Create an Admin User.
  2. Set only the following permissions: add_users, edit_users, del_users, view_users, view_conns, close_conns
  3. Login with the new Admin User
  4. "Folders" is still visible in the menu

Expected behavior

There should be a permission for the Folder section.

SFTPGo version

SFTPGo 2.5.3-a805a930-2023-06-29T10:57:43Z

Data provider

sqlite

Installation method

Community Deb package

Configuration

Nothing special, using ftp(s) and sftp with nginx proxy. Pretty much the default configuration.

Relevant log output

No response

What are you using SFTPGo for?

Enterprise

Additional info

No response

@Joshua2504 Joshua2504 added the bug Something isn't working label Jul 6, 2023
@drakkan
Copy link
Owner

drakkan commented Jul 8, 2023

folders are considered part of users for historical reasons, there was initially no separate database table and using REST API you can still auto-create folders when adding users. So add_users, edit_users, del_users permissions will also grant permissions on folders

@Joshua2504
Copy link
Contributor Author

Thank you so much for fixing this, @drakkan !

Do you know when this will be published and made available on the repositories?

@drakkan
Copy link
Owner

drakkan commented Jul 24, 2023

Thank you so much for fixing this, @drakkan !

Do you know when this will be published and made available on the repositories?

Not soon sorry, it is a breaking change, I expect a lot of complaints,, you will have to wait for v2.6.0.
Custom builds are included in the enterprise support plan (or an equivalent GitHub sponsorship)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants