Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mechanism to read AWS S3 access credentials from environment variables #1562

Closed
DeflateAwning opened this issue Mar 13, 2024 · 9 comments
Labels
suggestion Feature suggestion

Comments

@DeflateAwning
Copy link

Is your feature request related to a problem? Please describe.

In a deployment on AWS, I'd like to manage the S3 bucket access controls through IAM via policy, which generates the access credentials as environment variables.

Describe the solution you'd like

I'd like to be able to type something like [ENV_VAR:AWS_ACCESS_KEY] in the text fields to setup an S3 virtual folder, and have SFTPGo read the environment variable for those fields as such.

Describe alternatives you've considered

Currently you have to generate an insecure IAM user (against all the AWS warnings as you go through the process), and then paste in the secret values. These values aren't automatically rotated though, and have to enter the clipboard of developers.

If this already exists, I couldn't find it in the docs.

What are you using SFTPGo for?

Medium business

Additional context

image

@DeflateAwning DeflateAwning added the suggestion Feature suggestion label Mar 13, 2024
@drakkan
Copy link
Owner

drakkan commented Jun 15, 2024

This is already supported in the same way as the AWS SDK

@drakkan drakkan closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@DeflateAwning
Copy link
Author

Can you elaborate, and point to the applicable documentation?

@washaq00
Copy link

washaq00 commented Oct 6, 2024

Can you elaborate, and point to the applicable documentation?

@DeflateAwning Did you figure it out?

@DeflateAwning
Copy link
Author

No I did not; would you mind sharing the solution?

@drakkan
Copy link
Owner

drakkan commented Oct 7, 2024

There is nothing SFTPGo specific to document here. SFTPGo uses the AWS SDK, so just refer to the AWS docs, SFTPGo can use env vars the same way as AWS CLI for example.

I'm sorry if my first reply seemed or was rude. It probably would have been better not to reply at all.
I'm struggling to make the SFTPGo development financially sustainable and It's quite annoying to see SFTPGo used in environments where you pay for everything else and ask for free support here.

@DeflateAwning
Copy link
Author

My company is paying for a support license via the AWS Marketplace. We appreciate this project and your development efforts! :)

It would be great to be able to inject the S3 credentials as enviroment variables per-profile. I'm still not really sure how to do that though. No worries if you can't work on this; not essential, but a useful feature imo

@drakkan
Copy link
Owner

drakkan commented Oct 7, 2024

@DeflateAwning If you are using our Marketplace offer please contact us directly as explained in our AWS page.

Schermata del 2024-10-07 10-52-46

GitHub issues/discussions are for users asking for free support

@DeflateAwning
Copy link
Author

I'm not asking for support; I'm requesting that this feature be implemented and/or documented

@drakkan
Copy link
Owner

drakkan commented Oct 8, 2024

I'm not asking for support; I'm requesting that this feature be implemented and/or documented

yes, if you are a commercial user contact us directly, your requests will have higher priority, especially if we see that your subscription has been active for a long time. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestion
Projects
None yet
Development

No branches or pull requests

3 participants