Decorated attributes inaccessible in to_json

[danielstocks]

Hello, thanks for outstanding work on draper. I'm having a small issue:

Background:

class ArticleDecorator < ApplicationDecorator
  decorates :article
  PUBLIC_VISIBLE_ATTRIBUTES = [:title]

  def title
    "hello world"
  end

  def to_json
    attr_set = PUBLIC_VISIBLE_ATTRIBUTES
    article.to_json(:only => attr_set)
  end
end

Problem:

a = AricleDecorator.decorate(Article.first)
a.title # => "hello world"
a.to_json # => "{"title": "old title"}"

Am I doing this wrong?

[vizjerai]

Yes, because your calling article's to_json method directly through the decorator's to_json method where it doesn't know anything about the decorator.

class ArticleDecorator < ApplicationDecorator
  decorates :article

  def title
    "hello world"
  end

  def as_json(*args)
    {
      :title => title
    }
  end
end

a = ArticleDecorator.first
a.title # => "hello world"
a.to_json # => '{"title": "hello world"}'

[danielstocks]

That explains it, thanks.

[mpelzsherman]

Thanks, this helped me as well!

[barelyknown]

This was helpful. Thanks. It would be nice to have a to_json method for decorators that merged the decorator and active record objects so that you could use to_json shortcuts to build the hash.

[steveklabnik]

It would be nice to have a to_json method for decorators that merged the decorator and active record objects so that you could use to_json shortcuts to build the hash.

Any and all feature suggestions welcome as pull requests. ;) however, you may want to check out https://github.com/josevalim/active_model_serializers