Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'best()' to src/listing/mixins/base.dart #143

Closed
donovanrost opened this issue May 24, 2019 · 5 comments
Closed

Add 'best()' to src/listing/mixins/base.dart #143

donovanrost opened this issue May 24, 2019 · 5 comments

Comments

@donovanrost
Copy link
Contributor

There is subreddit.hot() / .top() / .rising()

.best() doesn't seem to be available, am I missing something?

@StefanLobbenmeier
Copy link
Contributor

Hi :) did you find a workaround? Otherwise I will probably try to patch this in a few month, but I am currently quite busy (and so is the actual owner of this repository)

@bkonyi
Copy link
Member

bkonyi commented May 28, 2019

If it's missing functionality, this shouldn't be too difficult to add. @donovanrost did you find a workaround or was this already implemented somewhere?

@bkonyi
Copy link
Member

bkonyi commented May 28, 2019

Actually, I'm fairly certain you can just use the stream provided by SubredditRef as Reddit sorts by 'best' by default as far as I can tell. It might be worth adding a best() method either way just for completeness.

@bkonyi bkonyi reopened this May 28, 2019
@bkonyi bkonyi changed the title How do you get 'best' of a subreddit? Add 'best()' to src/listing/mixins/base.dart May 28, 2019
@donovanrost
Copy link
Contributor Author

When I opened this issue I didn't realize that on reddit.com, the only subreddit that actually has a 'best' option is 'home' which, I think in DRAW is front. Every other subreddit has a 'hot' ordering which is provided by DRAW. The frontpage api should be the only one with a 'best' option

@bkonyi
Copy link
Member

bkonyi commented May 30, 2019

When I opened this issue I didn't realize that on reddit.com, the only subreddit that actually has a 'best' option is 'home' which, I think in DRAW is front. Every other subreddit has a 'hot' ordering which is provided by DRAW. The frontpage api should be the only one with a 'best' option

Right, that's why that was missing... totally forgot about that. You're correct that 'frontpage' is equivalent to 'home'. Anyway, thanks for clearing that up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants