Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic UI components & services #117

Closed
43 tasks done
wzhudev opened this issue Sep 9, 2023 · 4 comments · Fixed by #379
Closed
43 tasks done

Basic UI components & services #117

wzhudev opened this issue Sep 9, 2023 · 4 comments · Fixed by #379
Assignees
@jikkai @Dushusir @yuhongz
Labels
engineering
Milestone
Feature Milestone I

Comments

@wzhudev
Copy link
Member

wzhudev commented Sep 9, 2023 •
edited by jikkai
Loading

Implements basic components and services to improve code reuse and provide consistent behavior across different plugins and platforms.

Deadline Oct 14, 2023

Components

  • Message
  • Button
  • Icon: integrate @univerjs/icon
  • Input @Dushusir
  • InputNumber @Dushusir
  • Container
  • Layout
  • Slider
  • Tooltip

Docs

  • Design Token / Palette
  • Deploying storybook

Services

Services should be platform-agnostic.

  • ThemeService (manages themes and dark mode)
  • IMessageService

Deadline Oct 27, 2023

Components

  • Dropdown
  • CanvasIcon: rename CanvasIcon to BorderLine
  • Menu
    • Item
    • NeoCustomLabel
    • CustomLabel: completely deprecate theCustomLabel component
    • Select
  • ColorPicker
  • ColorPickerCircleButton

Deadline Nov 4, 2023

Components

  • Tabs
  • Dialog: rename Modal to Dialog
  • Notification @Dushusir
  • Confirm

Services

  • INotificationService @Dushusir
  • IDialogService
  • IConfirmService

Deadline Nov 11, 2023

Components

  • CellRange
  • Collapse
  • Separator
  • ResizeDialog
  • SiderModal
  • Avatar
  • Checkbox
    • CheckboxGroup
  • Radio
    • RadioGroup
  • Drag
  • Slot
  • Modal

Not in plan

Components
@wzhudev wzhudev added this to the Ship MVP milestone Sep 9, 2023
@jikkai jikkai mentioned this issue Sep 13, 2023
Merged
@jikkai jikkai linked a pull request Sep 13, 2023 that will close this issue
refactor(base-ui): components refactoring #136
Merged
@jikkai jikkai removed a link to a pull request Sep 13, 2023
refactor(base-ui): components refactoring #136
Merged
@wzhudev wzhudev mentioned this issue Sep 15, 2023
Closed
25 tasks
@wzhudev wzhudev modified the milestones: Ship MVP, Feature Milestone I Sep 16, 2023
@wzhudev wzhudev assigned Dushusir and ghost Sep 22, 2023
@wzhudev
Copy link
Member Author

wzhudev commented Sep 23, 2023

@jikkai Please schedule components development plan

@wzhudev wzhudev pinned this issue Sep 23, 2023
This was referenced Sep 23, 2023
Merged
Merged
@jikkai jikkai unassigned ghost Oct 8, 2023
This was referenced Oct 31, 2023
Merged
Merged
@jikkai jikkai unpinned this issue Nov 3, 2023
@ryanwwest
Copy link

I see 'dark mode' mentioned here - but is dark mode itself not actually implemented yet, there's just a manager ready for themes like dark mode?

@jikkai
Copy link
Member

jikkai commented Jul 24, 2024

I see 'dark mode' mentioned here - but is dark mode itself not actually implemented yet, there's just a manager ready for themes like dark mode?

Due to limited manpower, we have not yet scheduled the implementation of dark mode.

@lingchuL
Copy link

I see 'dark mode' mentioned here - but is dark mode itself not actually implemented yet, there's just a manager ready for themes like dark mode?

Due to limited manpower, we have not yet scheduled the implementation of dark mode.

very needed feature, may it come sooner~ Or are there any trick ways to implement dark mode for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jikkai jikkai

@Dushusir Dushusir

@yuhongz yuhongz

Labels
engineering
Projects
No open projects
MVP
Status: Done
Milestone
Feature Milestone I
Development

Successfully merging a pull request may close this issue.

feat(base-ui): support IDialogService & IConfirmService dream-num/univer
6 participants
@wzhudev @jikkai @Dushusir @ryanwwest @yuhongz @lingchuL