Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log only mode and Audit Trail #20

Open
nileshbhadana opened this issue Jan 8, 2024 · 3 comments · May be fixed by #21
Open

Log only mode and Audit Trail #20

nileshbhadana opened this issue Jan 8, 2024 · 3 comments · May be fixed by #21

Comments

@nileshbhadana
Copy link

nileshbhadana commented Jan 8, 2024

Summary

First of all, great effort and wonderful plugin. Gives us most of the features we are looking for out the box which are missing the OSS version.

There can be a log only mode which can help in deciding the scale and limits before actually starting to rate-limit the requests. It would be beneficial incase of first implementation where we can start the plugin in log only/audit only mode. And then refer the metrics before enforcing the rate-limiting rules.

Also, would be very much helpful if we can add an audit trail to figure out how many requests were rate-limited, and say when limiting on basis of any header eg. User-id, we can check out which particular user-ids were rate-limited and the number of requests. Though, this metric can be extracted out via plotting the 429's but that would a holistic view only. If we can log the ids or publish any time series metrics to plot it easily using prometheus that would be very helpful.

@nileshbhadana nileshbhadana changed the title Log only mode along with Audit Trail Log only mode and Audit Trail Jan 8, 2024
@nileshbhadana
Copy link
Author

Apart from this, a flag for fault toleration was added to OSS version in newer versions. Just wanted to ask if there is plan/roadmap to include it is in place?

@chirag-manwani
Copy link
Collaborator

There is no roadmap as such but happy to accept any help that improves the plugin and makes it better for all.
@nileshbhadana Would you be willing to contribute to add the above mentioned features?

@nileshbhadana
Copy link
Author

Hey @chirag-manwani , opened a PR for this.
Also added the upstream OSS flags which were added recently and were missing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants