-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log only mode and Audit Trail #20
Comments
Apart from this, a flag for fault toleration was added to OSS version in newer versions. Just wanted to ask if there is plan/roadmap to include it is in place? |
There is no roadmap as such but happy to accept any help that improves the plugin and makes it better for all. |
Hey @chirag-manwani , opened a PR for this. |
Summary
First of all, great effort and wonderful plugin. Gives us most of the features we are looking for out the box which are missing the OSS version.
There can be a log only mode which can help in deciding the scale and limits before actually starting to rate-limit the requests. It would be beneficial incase of first implementation where we can start the plugin in log only/audit only mode. And then refer the metrics before enforcing the rate-limiting rules.
Also, would be very much helpful if we can add an audit trail to figure out how many requests were rate-limited, and say when limiting on basis of any header eg.
User-id
, we can check out which particular user-ids were rate-limited and the number of requests. Though, this metric can be extracted out via plotting the 429's but that would a holistic view only. If we can log the ids or publish any time series metrics to plot it easily using prometheus that would be very helpful.The text was updated successfully, but these errors were encountered: