-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making it possible to configure Moco through Groovy script #45
Conversation
Some comments for the commit.
|
|
… Alttered moco_script.groovy to call full groovy config script instead of appending .groovy to the script name
|
Moco shell will download Moco from Maven repository if there is no Moco installed locally. On the other hand, it can upgrade Moco to latest version. It would be better if gmoco shell supports the same behaviour. |
…here is no Moco installed locally. It downloads the latest version possible.
The script works exactly as requested |
I've merged this pull request. Some improvement suggestions are as follow:
|
That's great! I'll try to take a look at it in free time. |
2. Refactored names of scripts 3. Added generated log and pid files to .gitgnore 4. Added shutdown hook for deamon version of moco that deletes the pid file 5. Refactored code
Commited all of the suggestions for improvements:
|
…ttp request implementation to replace two old implementations
Any chances of pushing the changes and closing the PR? ;) |
Together with @kurlenda we created a bash script that allows to configure and run Moco server through Groovy script. In addition it downloads groovy if one doesn't have GDK already installed on his drive.