Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorize embeddings #99

Closed
Optimox opened this issue Apr 28, 2020 · 0 comments · Fixed by #100
Closed

Refactorize embeddings #99

Optimox opened this issue Apr 28, 2020 · 0 comments · Fixed by #100
Assignees
Labels
enhancement New feature or request

Comments

@Optimox
Copy link
Collaborator

Optimox commented Apr 28, 2020

Feature request

Creating an external module for embeddings generation would make code clearer.
Some improvement to skip this part if no embeddings are needed would also make the training faster (see #97 ).

What is the expected behavior?
Nothing would change, just code optimization

What is motivation or use case for adding/changing the behavior?
Code clearer and faster.

How should this be implemented in your opinion?

Are you willing to work on this yourself?
yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants