Removed custom DB overrides in favour of in-container variables. #1017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were 3 levels of DB-ralted variables:
DREVOPS_MARIADB_*
MARIADB_*
The purpose of
DREVOPS_MARIADB_*
was to allow platform-independent DB credentials. But in practice, those are never changed in projects.In addition, having these values only in
.env
and not directly indocker-compose.yml
does not allow to rundocker compose exec *
commands with those variables loaded. As a result,docker compose exec drush st
cannot connect to the local DB.Note that
DREVOPS_MARIADB_*
was used only locally.MARIADB_*
is injected by Lagoon. For other providers, these are added through whole$database
variable override (like Acquia), so these are not used in prod at all.