Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed custom DB overrides in favour of in-container variables. #1017

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Sep 28, 2023

there were 3 levels of DB-ralted variables:

  1. DREVOPS_MARIADB_*
  2. MARIADB_*
  3. defaults

The purpose of DREVOPS_MARIADB_* was to allow platform-independent DB credentials. But in practice, those are never changed in projects.

In addition, having these values only in .env and not directly in docker-compose.yml does not allow to run docker compose exec * commands with those variables loaded. As a result, docker compose exec drush st cannot connect to the local DB.

Note that DREVOPS_MARIADB_* was used only locally. MARIADB_* is injected by Lagoon. For other providers, these are added through whole $database variable override (like Acquia), so these are not used in prod at all.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1017 (db1a0d8) into develop (c4d329d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #1017   +/-   ##
========================================
  Coverage    71.90%   71.90%           
========================================
  Files           50       50           
  Lines         3509     3509           
========================================
  Hits          2523     2523           
  Misses         986      986           
Files Coverage Δ
scripts/drevops/info.sh 0.00% <0.00%> (ø)

@AlexSkrypnyk AlexSkrypnyk merged commit 17dd7f0 into develop Sep 28, 2023
15 of 16 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/remove-db-overrides branch September 28, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released in 1.17
Development

Successfully merging this pull request may close these issues.

1 participant