Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1175] Show DrevOps variables in Lagoon only when $DREVOPS_DEBUG is set. #1182

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

AlexSkrypnyk
Copy link
Member

closes #1175

@AlexSkrypnyk
Copy link
Member Author

@sonnykt
Could you please review this.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36bbca9) 73.97% compared to head (6a80c02) 73.97%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1182   +/-   ##
========================================
  Coverage    73.97%   73.97%           
========================================
  Files           40       40           
  Lines         3001     3001           
========================================
  Hits          2220     2220           
  Misses         781      781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -15,7 +15,8 @@ tasks:
post-rollout:
- run:
name: Show DrevOps variables.
command: env -0 | sort -z | tr '\0' '\n' | grep ^DREVOPS_ || true
command: |
[ "${DREVOPS_DEBUG-}" = "1" ] && env -0 | sort -z | tr '\0' '\n' | grep ^DREVOPS_ || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ${DREVOPS_DEBUG-} the right syntax?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is a shortened version of "${DREVOPS_DEBUG:-}"

@AlexSkrypnyk AlexSkrypnyk merged commit 629eb07 into develop Feb 14, 2024
16 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/1175-prevent-post-rollout-show-vars branch February 14, 2024 23:15
@AlexSkrypnyk AlexSkrypnyk added this to the 1.19 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released in 1.19
Development

Successfully merging this pull request may close these issues.

Prevent lagoon post-rollout step from showing all variables
2 participants