Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#934] Simplified build.sh in favour of ahoy and CI. #1195

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Feb 18, 2024

closes #934

Changes

  • Removed build.sh in favour of commands in Ahoy and directly in CI
  • Moved the functionality of restore-docker-image.sh into download-db-docker-registry.sh
  • Cleaned up CircleCI config file:
    • Moved rarely used YAML anchor aliases into code
    • Updated DREVOPS_DB_DOCKER_IMAGE_BASE to 23.12.0
    • Fixed failure when no test artifacts files are available
  • Fixed ahoy cli not forwarding host env vars in interactive mode.
  • Rename $DREVOPS_DRUPAL_SHOW_LOGIN_LINK to $DREVOPS_SHOW_LOGIN
  • Fixed Rector using cache when processing files

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (cd81d9f) 74.39% compared to head (3161e05) 72.17%.

Files Patch % Lines
scripts/drevops/download-db-docker-registry.sh 0.00% 21 Missing ⚠️
scripts/drevops/info.sh 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1195      +/-   ##
===========================================
- Coverage    74.39%   72.17%   -2.23%     
===========================================
  Files           40       38       -2     
  Lines         2949     2857      -92     
===========================================
- Hits          2194     2062     -132     
- Misses         755      795      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/remove-buildsh branch 2 times, most recently from cd21cfc to d1f0881 Compare February 18, 2024 11:43
@AlexSkrypnyk AlexSkrypnyk changed the title Feature/remove buildsh [#934] Simplified build.sh in favour of ahoy and CI. Feb 19, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 4c86e94 into develop Feb 19, 2024
14 of 16 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/remove-buildsh branch February 19, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released in 1.20
Development

Successfully merging this pull request may close these issues.

Simplify build.sh in favour of ahoy and CI
1 participant