Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad indentation in Overview documentation code example #50

Closed
DrGFreeman opened this issue May 29, 2021 · 1 comment · Fixed by #53
Closed

Bad indentation in Overview documentation code example #50

DrGFreeman opened this issue May 29, 2021 · 1 comment · Fixed by #53
Labels
documentation Improvements or additions to documentation

Comments

@DrGFreeman
Copy link
Owner

The indentation of the dtype parameter and closing parenthesis in the get_df with dtype example in docs/overview.rst are incorrect:

df = get_df(
    table="players",
    keys=keys(player_id=["player_two", "player_four"]),
        dtype={
            "bonus_points": "Int8",
            "last_play": "datetime64[ns, UTC]",
            # "play_time": "timedelta64[ns]"  # See note below.
        }
    )

Should read:

df = get_df(
    table="players",
    keys=keys(player_id=["player_two", "player_four"]),
    dtype={
        "bonus_points": "Int8",
        "last_play": "datetime64[ns, UTC]",
        # "play_time": "timedelta64[ns]"  # See note below.
    }
)
@DrGFreeman DrGFreeman added the documentation Improvements or additions to documentation label May 29, 2021
@DrGFreeman
Copy link
Owner Author

The same issue is present in the README as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant