feat: hideOnStateChange should also hide on state change error

[vladipus]

Type: feat

Platform: all

Not exactly a bug maybe, but when the state change fails, the loading screen remains on screen and so the app gets stuck. The $stateChangeError should also be listened to, to hide the Loading, when the hideOnStateChange flag is used.

[mhartington]

Can you provide an example of this in a codepen?

[vladipus]

here you go http://codepen.io/vladius/pen/ByxdYa

[mhartington]

You can use the duration option

http://ionicframework.com/docs/api/service/$ionicLoading/

http://codepen.io/mhartington/pen/KwRvLm

[vladipus]

Thank you for your advice. However, I can't accept it as a solution for this reason: if the natural non-error delay will be greater than this value, the loading screen will mistakenly be hidden.

I've already fixed the issue in my local ionic modification. it is as easy as handling an error like this, in parallel to $stateChangeSuccess handler: deregisterStateErrorListener = $rootScope.$on('$stateChangeError', hideLoader);

I can't really see any argument against hiding the loading screen on errors, when the hideOnStateChange is set, can you?