Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ShowPager and new ion-slides #4987

Closed
chooseapp opened this issue Jan 17, 2016 · 8 comments
Closed

bug: ShowPager and new ion-slides #4987

chooseapp opened this issue Jan 17, 2016 · 8 comments
Labels
needs: reply the issue needs a response from the user

Comments

@chooseapp
Copy link

Type: bug

Ionic Version: 1.x

Platform: all

Maybe it is me, but with the new ion-slides, it is impossible to change the showPager Boolean.

I tried a lot of things, and nothing worked.

@privetr
Copy link

privetr commented Jan 17, 2016

Same problem here. I removed the condition ng-if="!showPager" in source code to avoid that pagination bullets are hidden when there are more than 10 slides.

@masimplo
Copy link
Contributor

Yeap same issue. showPager should be exposed in the directive API so that is can be manipulated externally.

scope: {
     options: '=',
     slider: '='
   },
   template: '<div class="swiper-container">' +
     '<div class="swiper-wrapper" ng-transclude>' +
     '</div>' +
       '<div ng-hide="!showPager" class="swiper-pagination"></div>' +
     '</div>',

@mjangelini
Copy link

@chooseapp @privetr @masimakopoulos I found a solution that worked for me was this:
$scope.options = { loop: false, initialSlide: 1, pagination: false };

Although the documentation for ion-slides is horrid and doesn't reveal anything at all. I just kind of guessed to see if it would work based on the Swiper API.

@jgw96 jgw96 added v1 labels Mar 14, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jun 29, 2016

Hello all! Is this still an issue with the latest version of ionic? Thanks!

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jun 29, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jul 3, 2016

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Jul 3, 2016
@maxehnert
Copy link

maxehnert commented Oct 25, 2016

@jgw96 Can we open this up again? It still seems to be an existing bug that I am currently experiencing.

@twinssbc
Copy link

@maxehnert You can use $scope.options = { pagination: false }; in the pre-link hook function.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 4, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

7 participants