chore(ionicons): remove the import of ionicons css #10115
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Importing the
ionicons.scss
file from ionicons was adding css that is not desired. Specifically, the.ion
class here: https://github.com/driftyco/ionicons/blob/3.0/dist/scss/ionicons.scss#L29-L41The
.ion
class itself isn't added to our icons, but it is extended here: https://github.com/driftyco/ionicons/blob/3.0/dist/scss/ionicons-common.scss#L941So because of this extend, each icon class was getting this css which caused issues all over the e2e tests and in Ionic apps as well. The rule that is causing the issues is
line-height: 1
.For example:
Changes proposed in this pull request:
node_modules/ionicons/dist/scss
from the sass config so that it won't importionicons.scss
from there and instead will import it fromsrc/fonts/
ionicons-icons
andionicons-variables
to include the full path withnode_modules
, because withoutionicons
in theincludePaths
it will throw errors that it can't find itIonic Version: 2.x