(chore): Add packaging for Meteor.js #3133

Closed
wants to merge 1 commit into
from

Projects

None yet
@Urigo
Contributor
Urigo commented Feb 18, 2015

Hi @adamdbradley @mlynch

I'm a package maintainer for Meteor.js, a popular full-stack JavaScript framework.

I'm also the creator of angular-meteor, a library that let's you work with AngularJS on top of Meteor.

A lot of our users use Ionic and it right now there is a separate package and Github repo that simply manually copies your distribution and publish it to Meteor.
There is also a Blaze copy of Ionic Framework.

This PR will allow you to directly publish updated versions of Ionic as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer to the driftyco organization there.

I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions of Ionic, you'll be able to publish them easily to Atmosphere.

As discussed by email, usually I also add the build process for automatically publishing the Meteor package but your build process is a little bit more complicated so as you requested, this pull request contains only the Meteor package files without any automatic scripts.

Thanks & best regards,
Uri

@perrygovier
Member

This is out of the scope for v1 of Ionic, but support is coming in v2.

@rbecheras

👍
Awesome, THANKS YOU @Urigo for your great works on angular-meteor and ionic-meteor !
Theses two projects are all I needed to fall down into meteor stack !
I am as you said an angular and ionic dev that actually use PHP but want to switch to fullstack and dreaming to migrate to meteor!
Did you even built some real apps (big or small app, no matter) like following :

  • meteor server side
  • meteor angular-alone browser side
  • and meteor-angular-ionic-cordova mobile device side ?

Could you provide examples of code or tutos of a such architecture ?

@perrygovier So, meteor will be "built-in" supported by ionic2/angular2 ?
If so, whats a great news !

@vieko
vieko commented May 5, 2015

👍

@skolade
skolade commented May 6, 2015

Thank @Urigo and @perrygovier! @perrygovier With the buss for Ionic 2.0 do you have an Alpha or Beta tester ETA

@rbecheras

👍 @skolade !
Is there a non-empty even embryonic work on this in the 2.0 roadmap ?

@perrygovier
Member

@rbecheras, the way Angular 2 and es6 itself is architected means angular and ionic wont conflict the same way it currently does, requiring a special project to smooth over the differences.

We've already started development on Ionic 2 and are in regular communication with the Angular team, building Ionic 2 as new features and functionality of Angular 2 are built out. Ionic 2 and Angular 2 are still very volatile still though. We will open source it when the dust settles a bit more.

@fungilation

+1 for official integration of meteor and ionic!

@rbecheras

Thanks @perrygovier, I'm pretty impatient to read the ionic announce ;-)

@SrimalPriyanga

Thanks @Urigo, angular-meteor library is amazing, when i start working with it one of my major problem was where is Ionic..? Meteor-Ionic solved it & it feel more comfortable. i wish these all libraries will work on ionic2 & angular2 also.
Great job keep it up 👍

@yogiben
yogiben commented May 26, 2015

+1 for official integration

Thank you @Urigo !

@pavlovich

+1 for official integration!

@zimt28
zimt28 commented May 28, 2015

👍

@pajooh
pajooh commented May 31, 2015

+1 for official integration

Thank you @Urigo !

@MilosStanic

+1 for official integration
thanks @urigo

@BurningDog

+1 for official integration!

@mardo
mardo commented Jun 19, 2015

+1 !

@mickdelaney

+1

@jonmc12
jonmc12 commented Jun 26, 2015

+1

@bonatoc
bonatoc commented Jul 8, 2015

+1

@gpike
gpike commented Jul 9, 2015

+1

@bLaKtivist

+1

@lukasbisdorf

+1

@omeid
omeid commented Jul 11, 2015

👍

@Msms-NJ
Msms-NJ commented Jul 13, 2015

+1

@woshidag

+1

@Saumik
Saumik commented Jul 25, 2015

+1 Dude Meteor + Ionic Support will be awesome. It's a match made in heaven 😆 👍

@MancDev
MancDev commented Jul 28, 2015

+1

@bonatoc
bonatoc commented Jul 28, 2015
for (i = 0; i < 1000; i++)
{
     console.log("+1");
}
@cesarve77

+1

@chrisbarry

+1

@iMagdy
iMagdy commented Aug 12, 2015

+1

@jdmswong

+1 !!

@perrygovier
Member

Damn you people are persistent... Giving this another look for v1

@perrygovier perrygovier reopened this Aug 12, 2015
@iMagdy
iMagdy commented Aug 12, 2015

Thanks @perrygovier :trollface:

@mardo
mardo commented Aug 12, 2015

@perrygovier You're the man!

@alungboy

+1

@mhartington
Member

Uri would you be able to bump the version in the package.json to make sure they match what we have in master.

@synnoc
synnoc commented Aug 20, 2015

+1

@Urigo
Contributor
Urigo commented Aug 22, 2015

@perrygovier @mhartington I've updated the pull request and released the latest version - https://atmospherejs.com/driftyco/ionic
Thanks and sorry for the delay!

@chrisbarry

Is there a thread talking about making it easier / possible to use the ionic CLI inside Meteor?

@nicholasalanbrown

Also how would I implement this? Would I need to use Angular? I'm currently
using Meteoric with my Blaze templates.

On Sat, Aug 22, 2015, 7:04 AM chrisbarry notifications@github.com wrote:

Is there a thread talking about making it easier / possible to use the
ionic CLI inside Meteor?


Reply to this email directly or view it on GitHub
#3133 (comment).

@Urigo
Contributor
Urigo commented Aug 22, 2015

@chrisbarry @nicholasalanbrown I'm working on a blog post the will be out soon that will demonstrate both ways of doing that (Using Meteor CLI and using the Ionic CLI)

@bonatoc
bonatoc commented Aug 24, 2015

@Urigo — great news.

@mirstan
mirstan commented Aug 25, 2015

+1

@mhartington mhartington and 2 others commented on an outdated diff Aug 25, 2015
meteor/override-fastclick.js
@@ -0,0 +1,6 @@
+// disable fastclick package in Meteor if included
@mhartington
mhartington Aug 25, 2015 Member

@Urigo is there any way we can avoid this? The PR looks good, just we're not too keen on this.

@Urigo
Urigo Aug 25, 2015 Contributor

@mhartington Why? this code cancels Meteor's FastClick so we will your yours like any other Ionic app

@perrygovier
perrygovier Aug 25, 2015 Member

We'd like to avoid having a meteor directory in the root of Ionic. We're not opposed to what it's doing, but is there another way to do it?

@Urigo
Urigo Aug 25, 2015 Contributor

ohh I see, then I can place it inside the package.js I think.
Or in any other place you want me to

@Urigo
Urigo Aug 25, 2015 Contributor

No actually not in the package.js, but any other place you want..

@perrygovier
perrygovier Aug 25, 2015 Member

Playing devil's advocate, is it possible for metor to check for ionic.tap?

@Urigo
Urigo Aug 25, 2015 Contributor

Do you mean inside the fastclick package?
My guess is that probably not and if so, it might take a while (like next version or something)
The good thing about that is here it's out of both of the platforms specific code and only in the integrating package

@Urigo
Urigo Aug 25, 2015 Contributor

We can also rename to folder to something more general like packaging or place it inside scripts or config which has build specific things

@perrygovier
perrygovier Aug 31, 2015 Member

If there's a file that accommodates a package manager, cool. So package.js is ok. I'd like to avoid functional code that gets added to the ionic.bundle.min.js whose only purpose is to accommodate other libraries. Is it possible to add that bit of code to another repo and include it via package.js? I know it seems silly, but it's a precedent that could bite us later if we don't do things right.

@divramod

+1

@CyrilSabbagh

+1!

@jacobdr
jacobdr commented Sep 4, 2015

+1

@Urigo
Contributor
Urigo commented Sep 9, 2015

@mhartington @perrygovier I've moved the fastclick cancellation code to a separate package.
Much nicer and cleaner now :)

@dtruel
dtruel commented Sep 15, 2015

+1!

@yodacom
yodacom commented Sep 22, 2015

+1

@lucasbento

+1

@projetsdiy

+1

@perrygovier
Member

ha, missed a char in my commit message. This has been added!
3fa5515

Thanks for your patience and efforts.

@Svenskunganka Svenskunganka referenced this pull request in ndxbxrme/generator-angular-meteor Sep 25, 2015
Merged

feat: add ionic framework support #16

@justin-umesh

@Urigo,

Great, Wonderful work your contributions towards Meteor is really mind-blowing keep up the good work.

@luisherranz

Will we be able to use this package in the future without any angular dependency?

Now that iconic doesn't require angular anymore, it would be great to use this official package instead of meteoric.

@fungilation

I concur. Integration with alternatives like React would be awesome.

On Sat, Oct 3, 2015 at 5:03 AM Luis Herranz notifications@github.com
wrote:

Will we be able to use this package in the future without any angular
dependency?

Now that iconic doesn't require angular anymore, it would be great to use
this official package instead of meteoric.


Reply to this email directly or view it on GitHub
#3133 (comment).

@luisherranz

Yep, being able to use Ionic with Meteor+Blaze or Meteor+React would be incredible.

@mhartington
Member

Ionic is still using Angular, and we're pretty happy with it.

Will we be able to use this package in the future without any angular dependency?

Now that iconic doesn't require angular anymore, it would be great to use this official package instead of meteoric.

@mhartington mhartington locked and limited conversation to collaborators Oct 3, 2015
@mhartington
Member

For those interested, here is a link to the @Urigo's tutorial about building an ionic app with meteor.

http://angular-meteor.com/ionic-tutorial/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.