fixed ion-footer transition problem #9121 #9597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ion-footer does not follow the move when the page is transitioning, but its children element are moved.
|
Hello, thanks for using Ionic! While we greatly appreciate your time and effort in making this PR we have decided to close this PR as it potentially creates breaking changes. You can see discussion about this in this issue. The TLDR is that the contents of footer should always be wrapped in an |
|
Still not working in Ionic 4.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
fixed the problem
Ionic Version: 2.x
Fixes: #9121
The ion-footer does not follow the move when the page is transitioning, but its children element are moved.