Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend from AttributeErrors in CloudPath.__del__ (#418) #419

Merged
merged 1 commit into from Apr 1, 2024

Commits on Apr 1, 2024

  1. Defend from AttributeErrors in CloudPath.__del__ (#418)

    * Defend from AttributeErrors in CloudPath.__del__
    
    If the CloudPath Client instance is incomplete, it may not have a
    file_cache_mode attribute. Using getattr defensively prevents the
    AttributeError from causing __del__ to exit early.
    
    * Update HISTORY
    
    * Fix tests by fixing a copy-paste mistake
    
    * Use None instead of object as dummy client.
    
    ---------
    
    Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>
    bryanwweber and jayqi committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8ce39c3 View commit details
    Browse the repository at this point in the history