Conversation
e9a6231
to
4618b21
Compare
interface/assets/css/project.css
Outdated
@@ -3,3 +3,5 @@ | |||
padding: 2px; | |||
width: auto; | |||
} | |||
|
|||
.top-buffer { margin-top:20px; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should follow the existing style to some degree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean? Currently, the main content of a page would be overlapped at the top to some degree by the navbar. Adding some margin to the content container in base.html
solves that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing CSS code/indentation/spacing style, not the final result.. sorry for the confusion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see! Yeah, that would be way better :)
interface/backend/static/tests.py
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
class SmokeTest(TestCase): | |||
def test_landing(self): | |||
url = reverse('static:home') | |||
url = reverse('static:open_image') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think elsewhere we are using hyphens in url name
attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the remark. I replaced all underscores in url names by hyphens.
@@ -7,16 +7,109 @@ | |||
{% endblock %} | |||
|
|||
{% block content %} | |||
{{ block.super }} | |||
{% verbatim %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% verbatim %}
always seems like a bad smell to me in Django. How come we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Vue.js template syntax collides with the Django template syntax. Django would e.g. try to render following statements like Candidate {{ index + 1 }}
or {{ candidate.centroid.x }}
by itself, although the variables are provided by the Vue.js template language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Vue.js template syntax collides with the Django template syntax
Getcha. I was wondering if we could move the {% verbatim %}
blocks to only surround the colliding javascript in that case? That would make it a bit clearer why, and implicitly so. Alternatively, we could move the JS to an external file. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd also prefer moving the tags so that they surround the "problematic" syntax as tightly as possible.
…hens, comment out documentation test
6b04066
to
b61d598
Compare
@lamby Thanks again for your feedback! I implemented it and squashed the commits. |
Thanks @WGierke — lamby |
This should add an "accordion" view that shows the candidate nodules for a selected image. The candidate fields
lidc_max_sensitiv, convnet_vgg, convnett_vgg_lidc, Slice
still need to be implemented in the back-end.Description
I added the front-end Vue.js implementation to display candidate nodules of an image based on the current API.
Reference to official issue
This addresses #35 .
Motivation and Context
The doctor should be able to quickly get an overview of candidate nodules including their probability of being cancer.
How Has This Been Tested?
I created two dummy candidates by letting the API return
The outcome was
CLA