Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python -m cyfi execution #122

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add support for python -m cyfi execution #122

merged 2 commits into from
Oct 11, 2023

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Oct 11, 2023

Adds a __main__.py file, which allows you to use python -m cyfi as an alternative way to access the CLI.

@render
Copy link

render bot commented Oct 11, 2023

Your Render PR Server URL is https://cyfi-pr-122.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ckivpbgmccbs73dnku7g.

ejm714
ejm714 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@ejm714 ejm714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me though curious what the main benefit of enabling python -m is

klwetstone
klwetstone approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@klwetstone klwetstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👍

@jayqi jayqi merged commit 74c1d05 into main Oct 11, 2023
7 checks passed
@jayqi jayqi deleted the jyq-python-m-execution branch October 11, 2023 15:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejm714 ejm714 ejm714 approved these changes

@klwetstone klwetstone klwetstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayqi @ejm714 @klwetstone