Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python extra for mkdocstrings #56

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Add python extra for mkdocstrings #56

merged 3 commits into from
Jun 3, 2022

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented May 30, 2022

mkdocstrings 0.19.0 requires that the python extra be explicitly installed.

Also, to make tests pass with this version, we needed to do #51 as well and drop support for Python 3.6.

Closes #55
Closes #51

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #56 (e9b0e3b) into main (1b44bc5) will decrease coverage by 2.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #56     +/-   ##
=======================================
- Coverage   97.6%   95.5%   -2.2%     
=======================================
  Files         13      13             
  Lines        514     517      +3     
=======================================
- Hits         502     494      -8     
- Misses        12      23     +11     
Impacted Files Coverage Δ
erdantic/typing.py 88.2% <0.0%> (-9.5%) ⬇️
erdantic/exceptions.py 90.6% <0.0%> (-7.0%) ⬇️
erdantic/base.py 97.2% <0.0%> (+0.1%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

HISTORY.md Outdated Show resolved Hide resolved
HISTORY.md Outdated Show resolved Hide resolved
@jayqi jayqi merged commit 91beca6 into main Jun 3, 2022
@jayqi jayqi deleted the 55-mkdocstrings-python branch June 3, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed build on main branch (tests #187) Drop support for Python 3.6?
3 participants