Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jupyter config initialize block code instead of a string #26

Closed
jayqi opened this issue Jun 8, 2020 · 0 comments · Fixed by #29
Closed

Make Jupyter config initialize block code instead of a string #26

jayqi opened this issue Jun 8, 2020 · 0 comments · Fixed by #29

Comments

@jayqi
Copy link
Member

jayqi commented Jun 8, 2020

From @pjbull (source):

let's see if there's a good way to store this block as Python code so it gets highlighting in source control and could be easier to test directly if we need to eventually. I think that we could either define the function and use inspect.getsource to get this code after the function is imported, or maybe just have it in a .py that we read instead of importing.

I personally like the idea of doing it in a function. Then we can pass in c as an argument, which would satisfy linting, and also make it possible to do some basic compatibility testing against Jupyter in the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant