Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Jupyter config initialize into a function #29

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Make Jupyter config initialize into a function #29

merged 1 commit into from
Jun 24, 2020

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Jun 14, 2020

  • Made the nbautoexport initialize block into a function.
  • Added unit tests against Jupyter configuration objects
  • Added unit test to check ExportFormat levels against nbconvert

Resolves #26

@jayqi jayqi requested review from r-b-g-b and pjbull June 14, 2020 20:14
@jayqi jayqi force-pushed the post-save-config-function branch from 8476338 to 48929b2 Compare June 23, 2020 03:48
@pjbull
Copy link
Member

pjbull commented Jun 24, 2020

🔥 🔥 🔥

@pjbull pjbull merged commit ba02417 into master Jun 24, 2020
@jayqi jayqi deleted the post-save-config-function branch June 28, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-b-g-b r-b-g-b Awaiting requested review from r-b-g-b

@pjbull pjbull Awaiting requested review from pjbull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Jupyter config initialize block code instead of a string
2 participants
@jayqi @pjbull