Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic v2 compatibility #119

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Pydantic v2 compatibility #119

merged 2 commits into from
Jul 18, 2023

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Jul 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #119 (bb9062b) into master (48c097a) will decrease coverage by 0.7%.
The diff coverage is 78.5%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #119     +/-   ##
========================================
- Coverage    98.5%   97.9%   -0.7%     
========================================
  Files           8       8             
  Lines         427     441     +14     
========================================
+ Hits          421     432     +11     
- Misses          6       9      +3     
Impacted Files Coverage Δ
nbautoexport/sentinel.py 95.9% <75.0%> (-4.1%) ⬇️
nbautoexport/utils.py 98.6% <83.3%> (-1.4%) ⬇️

@pjbull
Copy link
Member Author

pjbull commented Jul 10, 2023

Auto-running was disabled because of lack of repo activity(?), here's the test run:
https://github.com/drivendataorg/nbautoexport/actions/runs/5503874277

Copy link
Member

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comments

nbautoexport/sentinel.py Show resolved Hide resolved
@jayqi jayqi self-requested a review July 17, 2023 16:53
@github-actions
Copy link
Contributor

@pjbull pjbull merged commit ce3e0ac into master Jul 18, 2023
22 checks passed
@pjbull pjbull deleted the pydantic-v2 branch July 18, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants