Notify failed master build + Versioned docs #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayqi
commented
Sep 4, 2021
| @@ -1,13 +1,11 @@ | |||
| -c requirements.txt | |||
| -r requirements.txt | |||
There was a problem hiding this comment.
These are redundant because -e . will already include them since they are dependencies of nbautoexport.
|
Tests failing due to #76 |
jayqi
force-pushed
the
versioned-docs
branch
from
6841246
to
4656636
Compare
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
======================================
Coverage 98.1% 98.1%
======================================
Files 8 8
Lines 382 382
======================================
Hits 375 375
Misses 7 7 |
pjbull
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test workflow improvements
workflow_dispatchtrigger which enables manually triggering workflow in GitHub UIVersioned docs using CI
docs-masterwill publish tolatestversion on any merges to masterreleaseworkflow will publish and overwrite any previous docs with same<major>.<minor>version. The new version will also be tagged with(stable)and is assigned the aliasstable.We use
latestandstableto refer to master branch and current release, respectively, per Read the Docs naming convention. I've also updated the README badge to say "stable" instead of "latest".All docs are stored on the
gh-pagesbranch, and the workflows will push that branch to Netlify. I've manually backfilled existing releases. This won't be pushed to Netlify until the PR is merged. In the meantime, you can see https://erdantic.drivendata.org/ as an example.PR previews continue to work as-is without integration with the other versions.