-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: MySQL2 binary/varbinary types are incorrectly typed as strings instead of buffers #1188
Comments
There was a pull request for this, but it has been closed due to complications between the planetscale and mysql2 adapters differing in terms of behavior: |
💎 $200 bounty created by @tslater |
There's anyone already working on it? I would like to help with it 😄 |
@ologbonowiwi Do you think you can pound through it quickly? I thought there was someone on here that said they wanted to, but I only see it in my email and not here. I wonder if it was deleted? I say go for it since it's been a week and no sign of them. |
@ologbonowiwi Hey! Thanks for sending me a DM on linkedin, I have my github completely muted and missed this. I had tried getting it working but as in the PR, the I tried playing around to get it to work but ran into the issue that they both rely on the Life got busy and I converted to neon / postgress in my projects so I abandoned it. Hope I could help, but this is pretty complicated and I'm not sure how to fix it. Let me know if you need anything else! |
Thanks for the clarification, @ryanagillie; only this comment helped a lot! |
The work on #1253 from my side is mostly done, this was the last update from @AndriiSherman on the discord thread. Posting it here so we have the issue updated. |
What version of
drizzle-orm
are you using?0.28.5
What version of
drizzle-kit
are you using?0.19.13
Describe the Bug
The mysql2 library parses binary & varbinary columns as Buffer.
They also automatically convert Buffers to hex strings, so passing those in to a query is escaped correctly.
Expected behavior
The type should be Buffer
Environment & setup
Generally
The text was updated successfully, but these errors were encountered: