Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/make binary and varbinary accept buffer #1253

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

ologbonowiwi
Copy link

@ologbonowiwi ologbonowiwi commented Sep 19, 2023

  • test: create test allowing buffer use for binary column
  • test: write test enforcing retro compatibility
  • feat: return buffer always for binary type
  • test: update zod tests to work with binary buffer
  • test: update drizzle-valibot tests to work with binary buffer
  • test: update drizzle-typebox tests to work with binary buffer
  • chore: fix mispelling
  • test: create test ensuring varbinary retro compatbility + buffer type
  • feat: make possible to receive buffer on varbinary
  • test: set missing length on varbinary creation
  • test: set varbinary as buffer on typebox, valibot and zod

this is the continuation of the job started on #425.
/claim #1188

@ologbonowiwi
Copy link
Author

@AndriiSherman, can you review this? the bounty can be collected only once the PR is merged 😄

@AndriiSherman AndriiSherman changed the base branch from main to beta January 5, 2024 10:35
@AndriiSherman
Copy link
Member

So far looks good to be merged. Can you please sign all the commits so I can merge this PR?

@tslater
Copy link

tslater commented Apr 3, 2024

@ologbonowiwi @AndriiSherman Any updates on this? Anything we can do to help move it along?

@ologbonowiwi ologbonowiwi force-pushed the feat/make-binary-and-varbinary-accept-buffer branch from 090cee3 to 5e3aef1 Compare April 3, 2024 20:22
@ologbonowiwi
Copy link
Author

@tslater is pretty much done on my side. I'm waiting for @AndriiSherman.

For precaution, I solved the conflicts. It should be ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants