Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output type of Star::get_max to Option<T> #18

Open
ihowell opened this issue Sep 8, 2021 · 0 comments
Open

Change output type of Star::get_max to Option<T> #18

ihowell opened this issue Sep 8, 2021 · 0 comments

Comments

@ihowell
Copy link
Collaborator

ihowell commented Sep 8, 2021

Change output type to Option<T>

nnv-rs/src/star.rs

Lines 338 to 343 in 135fc2d

/// TODO: Change output type to Option<T>
pub fn get_max(&self, idx: usize) -> T {
let neg_one: T = std::convert::From::from(-1.);
let eqn = self.representation.get_eqn(idx) * neg_one;
if let Some(ref poly) = self.constraints {


This comment was generated by todo based on a TODO comment in 135fc2d in #16. cc @DrKwint.

Originally posted by @todo[bot] in #16 (comment)

@DrKwint DrKwint changed the title ## Change output type to Option&lt;T&gt; Change output type of Star::get_max to Option<T> Sep 8, 2021
@DrKwint DrKwint added this to the Maintenance Cycle #1 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants