Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer fails to find the required files #38

Closed
neuromancer opened this issue Feb 28, 2019 · 6 comments
Closed

Installer fails to find the required files #38

neuromancer opened this issue Feb 28, 2019 · 6 comments

Comments

@neuromancer
Copy link

I tried the latest revision of this mod using the Archive.org CD version of Dark Reign, but it fails to find the required files when the CD image is mounted (in ArchLinux). Maybe the checksum is not correct?

$ md5sum /run/media/g/DKREIGN/install/data/dark/graphics/sprites.ftg 
30e26c563822b646cef9fc6c01d13d0f  /run/media/g/DKREIGN/install/data/dark/graphics/sprites.ftg
@drogoganor
Copy link
Owner

Hi, thanks for the report. I'll check out the archive.org version tonight. Most certainly it's the checksum.

@drogoganor
Copy link
Owner

Hi, I gave this a go on Windows but was unable to reproduce the issue with the Archive.org version. Are you sure you clicked the Detect Disc button on the Advanced screen? It's a bit of a run-around really. I'll have to get a linux environment up and running to really test this.

@neuromancer
Copy link
Author

Uhm, interesting. Where OpenRA is checking for mounted discs exactly? I'm using FUSE (in the Gnome desktop), but maybe I should mount the iso using the mount command?

@GraionDilach
Copy link

Besides checking for actual CD types, the following fallback places are used:
"/media/openra",
"/media/username/openra",
"/mnt/openra"

@neuromancer
Copy link
Author

IMHO it doesn't make a lot of sense to look for the mounted CD in that locations. I know this is an OpenRA mod, so that's the default behavior. I would be happy to submit a PR to fix this, modifying the Widgets/Logic/Installation/InstallFromDiscLogic.cs file, but I'm not really sure how to override it from this mod. In fact, I believe this should be fixed upstream: the DetectContentDisks() function:

https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Widgets/Logic/Installation/InstallFromDiscLogic.cs#L109-L131

should have a parameter to allow mods to override default locations.

@drogoganor
Copy link
Owner

I have now altered the mod so it installs content from the demo again. This should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants