Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Front-end eslint-plugin-jsdoc@39.7.5 do not support node version 20.x and higher #2002

Closed
1 task done
Thespica opened this issue May 17, 2024 · 2 comments · Fixed by #2005
Closed
1 task done
Labels
bug Something isn't working

Comments

@Thespica
Copy link
Contributor

Thespica commented May 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I built front-end with node 20.x, met error:

~/hertzbeat/web-app$ yarn install --registry=https://registry.npmmirror.com
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error eslint-plugin-jsdoc@39.7.5: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

But the documentation here and here declared that the only requirement for node version is higher(including) than 18.

Expected Behavior

Build front-end successfully.

Steps To Reproduce

node version: v20.12.2

npm version: 10.5.0

yarn version: 1.22.22

Environment

HertzBeat version(s): current(1.5.0 ~ 1.6.0)

Debug logs

~/hertzbeat/web-app$ yarn install --registry=https://registry.npmmirror.com
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error eslint-plugin-jsdoc@39.7.5: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Anything else?

If I am right, I wanna help solving this problem. Here are two solutions:

  1. update documentation to add an up-bound 19 node version.
  2. update eslint-plugin-jsdoc version(personally prefer).
@Thespica Thespica added the bug Something isn't working label May 17, 2024
@Thespica Thespica changed the title [BUG] Front-end eslint-plugin-jsdoc@39.7.5 do not support node version 20.x and higher [Question] Front-end eslint-plugin-jsdoc@39.7.5 do not support node version 20.x and higher May 17, 2024
@Thespica
Copy link
Contributor Author

Thespica commented May 17, 2024

I have dealt with this problem by updating eslint-plugin-jsdoc to 48.2.5.

@tomsun28
Copy link
Contributor

I have dealt with this problem by updating eslint-plugin-jsdoc to 48.2.5.

👍 hi, i current use node v18.18.0, can you submit a pr to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants