-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compression / gzip #21
Comments
I've forked and implemented it here master...jpillora:master I modified the dockerfile to get it to also build the binary, though when testing it on my drone server, it seems as if it's not picking up any of the options: |
|
Just tried reverting the Dockerfile and building outside of Docker and its still not picking up the |
You can upload S3 objects with
Content-Encoding: gzip
and the majority HTTP clients will automatically decompress during the GET.As an API, I'm thinking a simple
compress: true
/gzip: true
yaml setting will suffice.If we wanted to take it further, there could be a list of files to gzip, or a list of included file types, or maybe the smartest thing to do is a excluded file types (with defaults: mp3, jpg, gz, zip) - basically so we don't compress files which are already compressed.
I'm just looking into creating custom Drone plugins now so I can send a PR. Does this addition sound okay?
The text was updated successfully, but these errors were encountered: