Cmake refactor for gtest #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bring in gtest through fetchcontent * Use cmake options * Use target properties and link flags instead of global properties * Stop globbing * Bump cmake min version to match 22.04 * Reduce random variables that aren't used * Stop referring to directories above current cmake * Properly use CTest to allow optional testing * Solves dronecan#28 Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
…ather than global CANARD_CXX_FLAGS Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Ryanf55
commented
May 1, 2023
CMakeLists.txt
Outdated
| #list(APPEND SRC_FILES ${DSDL_GENERATED_SOURCES}) | ||
|
|
||
| # check arguments for 32-bit build | ||
| option(CMAKE_32BIT "Enable 32 bit build" ON) |
There was a problem hiding this comment.
Move this down to where it's used.
bugobliterator
force-pushed
the
cmake-refactor-for-gtest
branch
2 times, most recently
from
4fb1073
to
429d198
Compare
bugobliterator
force-pushed
the
cmake-refactor-for-gtest
branch
2 times, most recently
from
a44e3cc
to
6eafbda
Compare
bugobliterator
force-pushed
the
cmake-refactor-for-gtest
branch
8 times, most recently
from
8303516
to
187d1d7
Compare
bugobliterator
force-pushed
the
cmake-refactor-for-gtest
branch
from
187d1d7
to
7d2b1cf
Compare
Ryanf55
commented
May 17, 2023
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* This verifies the same version is used everywhere Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
|
Hi @bugobliterator , can you please allow this workflow to build, and give it a review? |
bugobliterator
approved these changes
May 26, 2023
| set(MODULES_DIR ${CMAKE_CURRENT_SOURCE_DIR}/modules) | ||
| set(TEST_DIR ${CMAKE_CURRENT_SOURCE_DIR}/tests) | ||
| # | ||
| # Copyright (c) 2016-2017 UAVCAN Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the cmake code to build and test from top level of the project.